Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: write workflow snapshot tests #381

Merged
merged 22 commits into from
Nov 14, 2024
Merged

test: write workflow snapshot tests #381

merged 22 commits into from
Nov 14, 2024

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Oct 25, 2024 •
edited
Loading

Changes

  • N/A

ticket: AC-4068

How to run test & test plan

link

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@liamcho liamcho requested a review from bang9 October 25, 2024 03:59
@liamcho liamcho self-assigned this Oct 25, 2024
@liamcho liamcho marked this pull request as draft October 25, 2024 03:59
@netlify Netlify
Copy link

netlify bot commented Oct 25, 2024 •
edited
Loading

✅ Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit 6f0a58e
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/67358ff47f29d6000841edad
😎 Deploy Preview https://deploy-preview-381--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamcho liamcho removed the request for review from bang9 October 25, 2024 04:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Size Change: +110 B (+0.02%)

Total Size: 603 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB -2 B (-0.05%)
./dist/__bundle-b5ef7de4-********.js 890 B -2 B (-0.22%)
./dist/index-********.js 306 kB +70 B (+0.02%)
./dist/index.es.js 173 B -1 B (-0.57%)
./dist/index.umd.js 283 kB +57 B (+0.02%)
./dist/Placeholder.error-********.js 344 B -2 B (-0.58%)
./dist/Placeholder.loading-********.js 183 B -3 B (-1.61%)
./dist/Placeholder.noChannels-********.js 182 B -2 B (-1.09%)
./dist/Placeholder.noMessages-********.js 182 B -2 B (-1.09%)
./dist/PlaceholderCommon-********.js 244 B -3 B (-1.21%)
ℹ️ View Unchanged
Filename Size
./dist/__bundle-7c3d40f4-********.js 21 B
./dist/style.css 8.62 kB

compressed-size-action

@liamcho liamcho force-pushed the test/AC-4068-snapshot-tests-send-user-message branch 2 times, most recently from ebf64c3 to baa1f24 Compare October 25, 2024 06:30
@liamcho liamcho changed the title test: write snapshot tests - send user message test: write workflow snapshot tests Nov 7, 2024
@liamcho liamcho requested review from bang9 and removed request for bang9 November 7, 2024 02:30
@liamcho liamcho force-pushed the test/AC-4068-snapshot-tests-send-user-message branch 5 times, most recently from 1c99e38 to de0b14a Compare November 8, 2024 09:56
@liamcho liamcho marked this pull request as ready for review November 8, 2024 10:11
@liamcho liamcho force-pushed the test/AC-4068-snapshot-tests-send-user-message branch from aa0a6be to f9f9671 Compare November 11, 2024 01:32
@semgrep-sendbird
Copy link

Semgrep found 1 ssc-cee3e6d5-d7c8-4c35-9815-076aa1ebfd49 finding:

Risk: Affected versions of rollup are vulnerable to Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting').

Fix: Upgrade this library to at least version 4.22.4 at chat-ai-widget/yarn.lock:15827.

Reference(s): GHSA-gcx4-mw62-g8wm, CVE-2024-47068

⚪️ This finding does not block your pull request.


Ignore this finding from ssc-cee3e6d5-d7c8-4c35-9815-076aa1ebfd49.

bang9
bang9 reviewed Nov 11, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@liamcho liamcho force-pushed the test/AC-4068-snapshot-tests-send-user-message branch from 6858c3c to cdd3db0 Compare November 13, 2024 04:04
@liamcho liamcho requested a review from bang9 November 13, 2024 04:13
@liamcho liamcho force-pushed the test/AC-4068-snapshot-tests-send-user-message branch from a38d5d5 to b4f9e92 Compare November 13, 2024 04:43
@liamcho liamcho force-pushed the test/AC-4068-snapshot-tests-send-user-message branch from f9e2f18 to a03db5b Compare November 13, 2024 05:26
@bang9 bang9 removed the request for review from AhyoungRyu November 13, 2024 05:34
bang9
bang9 reviewed Nov 13, 2024
View reviewed changes
src/main.tsx Outdated Show resolved Hide resolved
bang9
bang9 reviewed Nov 13, 2024
View reviewed changes
src/utils/messages.ts Outdated Show resolved Hide resolved
@liamcho @bang9
Update src/main.tsx
9a8a65d 
Co-authored-by: Hyungu Kang | Airen <[email protected]>
@liamcho liamcho requested a review from bang9 November 13, 2024 05:55
bang9
bang9 reviewed Nov 13, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
bang9
bang9 reviewed Nov 13, 2024
View reviewed changes
__visual_tests__/const.ts Outdated Show resolved Hide resolved
@liamcho liamcho requested a review from bang9 November 13, 2024 06:24
@liamcho liamcho force-pushed the test/AC-4068-snapshot-tests-send-user-message branch 3 times, most recently from 861fb22 to c5eac73 Compare November 14, 2024 02:32
@liamcho liamcho force-pushed the test/AC-4068-snapshot-tests-send-user-message branch from e629eaa to af1b57c Compare November 14, 2024 02:58
bang9
bang9 reviewed Nov 14, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
bang9
bang9 reviewed Nov 14, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
bang9
bang9 reviewed Nov 14, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
bang9
bang9 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

liamcho and others added 4 commits November 14, 2024 13:13
@liamcho liamcho merged commit dc69f05 into develop Nov 14, 2024
12 checks passed
@liamcho liamcho deleted the test/AC-4068-snapshot-tests-send-user-message branch November 14, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bang9 bang9 bang9 approved these changes

Assignees

@liamcho liamcho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamcho @bang9